First version of the OSI spec - #2
Closed
sfc-gh-kbhatia wants to merge 4 commits into
Closed
Conversation
hahmadi
reviewed
Dec 11, 2025
| # Optional: Additional context for AI tools (e.g., custom prompts, instructions) | ||
| ai_context: string | ||
|
|
||
| # Required: Collection of logical datasets(fact and dimension tables) |
Contributor
There was a problem hiding this comment.
Suggested change
| # Required: Collection of logical datasets(fact and dimension tables) | |
| # Required: Collection of logical datasets (fact and dimension tables) |
| relationships:[] | ||
|
|
||
| # Optional: | ||
| # These metrics can span one or more logical datasets and use relationships |
Contributor
There was a problem hiding this comment.
Suggested change
| # These metrics can span one or more logical datasets and use relationships | |
| # These metrics can span one or more logical datasets and use relationships |
| # Logical Dataset Schema | ||
| # Represents business entities or concepts (fact and dimension tables) | ||
| # Fields are defined within the scope of a logical dataset | ||
| datasets: |
Contributor
There was a problem hiding this comment.
I'm wondering if additional information needs to be captured here to identify which system/deployment/region etc the dataset maps to. (something like a connection spec). Have you considered that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced with this PR
#3